All depends on what you are looking for - but 2 of our favourites are:

El Husseins - up by the new market, just passed Luxor Temple (ethnic & cheap - no alcohol served)
John & Johns - run by 2 English guys situated inside the Gaddis Hotel. Huge portions!

CwB

Thanks, We eat anything and everything!! Not hotel people either thats why we've chosen Luxor to go out and about. Jazz

Top places to visit for me..
Valley of the Kings
Valley of the Nobles
Valley of the Queens
Valley of the Artisans
Queen Hatshepsut's temple
Karnak temple
Luxor temple
Medinat Habu
Luxor museum + Mummification museum
Colossi of Memnon
Google the sights to give you more ideas.

Top things to do...aside from visiting all the above!....

Private sailing on a traditional felucca with an Egyptian meal served onboard. I did this last year. Cost £10pp. You get to have a lovely meal brought to you from the West Bank (where the Valley's are located)which is cooked by a local woman and watch the sun set as you sail along the Nile. I always recommend this, it really is lovely.

Hot air balloon ride - I have done this twice now. I paid £30pp last year. You fly above the West Bank and some of Luxor town depending on the winds, again amazing to do.

Fellah's tent - this is a traditional egyptian night. Most people enjoy it. It is held at the hotel I stay at called the Jolie Ville. You get to see snake charmers, dervlish dancers, belly dancers and Cleo the camel amongst other things. It includes all your drink and food. I think the cost is about £30 per adult.

Dendera daytrip - One day cruise leaving around 7am and returning around 7pm. Sail down the Nile to Dendera to see the temple. Food included. Ship is called the Lotus I think if you want to find out more online. This costs around £30 and again is recommended with regular visitors to Luxor.

Restaurants..Lots of them in Luxor...some that are known as good are....
Sofra - typical egyptian food set in a beautiful building. they are online and you can view the menu. Very reasonable.
Kebabgy's - This hotel is on the lower corniche opposite the Old Winter Palace hotel. Good food with a Nile view. Well priced.
7 days 7 ways- english and egyptian food, very cheap
Maxime's - similar to the above
Snobs - popular restaurant serving good food with supposedly the best chips in Luxor!
There are also the usual fast food places that seem to impregnate any tourist area nowadays...McDonalds, Pizza Hut and KFC.

Yeah
But at least Macdonalds blends quite nicely into the scenery since they wouldn't let them put up the usual huge letter M.

Go to the top floor and take in the views across to the Luxor Temple. Cheapest Macdonalds we've been to!

CwB

so true! but watch the portion sizes, they are really big

Thank you!! I am getting excited!! Went to book a real bargain but we were to late!! So now looking again.
Jazz

Afternoon tea, on the terrace in front of the Old Winter Palace hotel. Elegant - slightly pricey - but a taste of an Egypt now vanishing.

Been a couple of years since we've done that, Sancho, but couldn't agree more! What a place to sit and watch the world go by too! With all these recent "alterations" to Luxor that I've been hearing of, I take it the OWP is still the same?