We have visited Taba, Sharm and Hurghada...but we have only ever visited Egypt to go diving.
Each of the resorts had an appeal and something to offer for me. I enjoyed Taba as it was very quiet and peaceful and close to the border with Israel,so I could go on the trip to Jerusalem. Also, (if we had still been there, I would have done the trip to Jordan). The security was quite tight becuase of the proximity to Israel but Taba heights is a purpose built resort about 40 mins from the airport. The downside is there is not much there..but it depends what you want from your holiday. I would return to Taba..but only so I could do the trips into Israel and Jordan. The diving is very picturesque..it is where I did my first ever proper try dive when we went to Tiran Island.
Sharm is Sharm..and I did not enjoy the chaos on the jetty every morning scrambling for dive boats...again, it depends what you are looking for in a holiday. There are plenty of places to eat and drink, plenty of entertainment and squillions of tat shops.
Hurghada is the place I have been the most....the Egyptians have spent alot of money improving this resort..again there is something for everyone..and there are quite alot of Russians who visit there.
I decided some time ago that I prefer to actually go to sea for a week when we go there, so generally we fly to Hurghada, go straight to the jetty and set sail for a weeks excellent diving.
If I had to pick one of those 3 to be land based I would say Taba.